Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed one set_opts use for PyCurl multirequest #11070

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Apr 6, 2022

Fixes #11066
Complement to #11069

Status

ready

Description

The multirequest method also relies on set_opts, meaning that the response object will be automatically decoded and we should not have the home-made decompress logic called.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Complement for: #11069

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 3 changes in unstable tests
  • Python3 Pylint check: failed
    • 1 warnings and errors that must be fixed
    • 1 warnings
    • 57 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12988/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amaltaro this seems to be the place that @vkuznet was mentioning

@todor-ivanov
Copy link
Contributor

Thanks @vkuznet
Merging and releasing the new tag now.

@todor-ivanov todor-ivanov merged commit 474fe9d into dmwm:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong gzip compression recognized/identified by header
4 participants