Enhance logic to map ScramArch to OS #11088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @mapellidario Dario, if I am not wrong, you were working with this code (or the one in Scram.py). |
smuzaffar
reviewed
Apr 12, 2022
|
|
||
| Returns: | ||
| string to be matched for OS requirements for job | ||
| :param scramArch: string of list of scramArches defined for a given job |
There was a problem hiding this comment.
may be it should be "string or list of ...." :-)
There was a problem hiding this comment.
Thanks! Typo fixed.
|
Jenkins results:
|
typo in the docstring
amaltaro
force-pushed
the
fix-11081-take2
branch
from
d83e8ba
to
dacc5b9
Compare
|
looks good |
|
Jenkins results:
|
|
Thanks for your review, Shahzad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11081
Status
ready
Description
The previous logic was checking whether the first part of the ScramArch was
inthe ScramArch defined in the logic, which of course can fail if we test a substring like"el8" in "el888_amd64_gcc630". Of course, it's very likely to become a problem, but I think it's worth changing it.This PR changes it and now we check for equality.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Meant to fix a typo in this PR: #11083, but now it became a minor refactoring.
External dependencies / deployment changes
None