move ckey/cert functions to Utils.CertTools

[vkuznet]

Partially Fixes #11098 (moving cert/ceky function will allow to share code between MicroServices and DBS services)

Status

ready

Description

Move functions ckey and cert into Utils.CertTools which is generic place to import from other places. This will allow to share and use this code in different Services, like MicroServices and DBS.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

See #11099 , if applied then I can safely remove these functions from #11099 and use common code.

External dependencies / deployment changes

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 7 tests added
• Python3 Pylint check: failed
  • 5 warnings and errors that must be fixed
  • 12 warnings
  • 48 comments to review
• Pylint py3k check: failed
  • 2 warnings
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13040/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 7 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 12 warnings
  • 47 comments to review
• Pylint py3k check: failed
  • 2 warnings
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13041/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 7 tests added
  • 2 changes in unstable tests
• Python3 Pylint check: succeeded
  • 12 warnings
  • 47 comments to review
• Pylint py3k check: failed
  • 2 warnings
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13043/artifact/artifacts/PullRequestReport.html

[vkuznet]

@amaltaro this PR is ready for review. One note though. The py3k lint checks fail with round built-in referenced which is explained here https://stackoverflow.com/questions/59533912/what-is-the-alternative-to-built-in-round. I think we should not degrade about py2 compatibility and the pylint documentation suggests that it is only for backward compatibility, and therefore it should be ignored or it is better to adjust pylint configuration to skip this test.

[todor-ivanov]

Thanks @vkuznet
The code looks good to me.
And also thanks for fixing two of the old standing pylint warnings.

[amaltaro]

This looks good to me, Valentin. However, given you are already on this, could you please update the same in this module:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/MicroService/Tools/PycurlRucio.py#L32-L38
?

Keep in mind there is an import that we can likely remove as well.

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 7 tests added
  • 4 changes in unstable tests
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 13 warnings
  • 65 comments to review
• Pylint py3k check: failed
  • 2 warnings
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13045/artifact/artifacts/PullRequestReport.html

[vkuznet]

Alan, I corrected PycurlRucio.py as well. Please review again.

[amaltaro]

Thanks Valentin, it looks good to me. Regarding pylint 3k, Erik and I had a brief chat and we also think it could be removed (AFAIR it checks whether our py2 code is compatible with py3, in some sense).