Fix manage path in the restartComponent script #11572
Conversation
|
Jenkins results:
|
|
This proposal actually drops the |
Valentin.s review Accept list of component names via script argument update release version in the example deployment command
amaltaro
force-pushed
the
fix-11492-take2
branch
from
343ee3a
to
e500e6b
Compare
|
Jenkins results:
|
|
This has been tested in the FNAL agent. |
| else | ||
| WMA_PATH="/data/srv/wmagent/current/install/wmagentpy3" | ||
| if [ ! -d "$install" ]; then | ||
| install="/data/srv/wmagent/current/install/wmagentpy3" |
There was a problem hiding this comment.
I know the following component does not relate to this exact script (so no action expected - just a comment).
I think python3 is the de-facto only version we are going to support from now on... and we never plan to move back to py2 or to prolong any support of it.So we should think of getting rid of this py3 suffix.
There was a problem hiding this comment.
Yes, I thought the same as well. The positive aspect of keeping this logic around is that it will ease the migration process to a new major python release. However, there is no release date for python4 neither certainty that it will be ever released.
| TAIL_LOG=`tail -n100 $COMPLOG` | ||
| $WMA_PATH/manage execute-agent wmcoreD --restart --components=$comp | ||
| $manage execute-agent wmcoreD --restart --components=$comp |
There was a problem hiding this comment.
It is indeed better. It seems in the previous version this script must have been failing completely ....
Fixes #11492
Superseeds #11493
Status
ready
Description
Instead of redefining variables to be used in this script, just use those already defined in the
env.shscript.Fix the
$installvariable if needed (artifact from python2 vs python3 WMAgent).Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None