Remove postToAMQ (post_to_amq) and fix typo in doc_type_amq

[vkuznet]

Fixes https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/214
Related to #11429

Status

ready

Description

Removed post_to_amq configuration parameter and local variable postToAMQ since they are not used in a code and fixed typo doc_to_amg to doc_to_amq which is used in MSPIleup configuration.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

<If it's a follow up work; or porting a fix from a different branch, please mention them here.>

External dependencies / deployment changes

<Does it require deployment changes? Does it rely on third-party libraries?>

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
• Python3 Pylint check: succeeded
  • 1 warnings
  • 4 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 1 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14229/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 2 new failures
  • 2 tests no longer failing
  • 1 changes in unstable tests
• Python3 Pylint check: succeeded
  • 1 warnings
  • 4 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14230/artifact/artifacts/PullRequestReport.html

[amaltaro]

Changes look good to me. Can you please squash these 2 commits though?

In order to push in a clean patch release into CMSWEB, we will have to backport this fix to a different branch (I just created 2.2.0.2_cmsweb). We can then backport it and cut a new release like 2.2.0.3.

I foresee releasing a 2.2.0.4 at some point today/tomorrow, for WMAgent purposes. But that will definitely be using 2.2.0.2_wmagent branch.

[vkuznet]

squash is done.

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 3 tests no longer failing
• Python3 Pylint check: succeeded
  • 1 warnings
  • 4 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14231/artifact/artifacts/PullRequestReport.html

[amaltaro]

@vkuznet Valentin, please backport it to 2.2.0.2_cmsweb branch, i.e., create a new PR by cherry-picking this changes and open the PR against the branch aforementioned. We will then merge that and cut a 2.2.0.3 release.

[vkuznet]

Done, see #11574