New CouchDB view for WorkQueue OpenForNewData requests #11611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
Make a specific function for dealing with open running requests Support stale parameter When aborting/force-completing, close the workqueue_inbox element Update element in workqueue_inbox db Use updateBulkDocuments method Update is nested
|
Jenkins results:
|
vkuznet
approved these changes
Jun 15, 2023
|
After a few bugfix + testing iterations, I can confirm that this patch is now fully functional. Default workflow transition has been tested, in addition to force-completing and aborting workflows. Note that it requires an update to the couchapps, which can be done in the CouchDB nodes with a command similar to: followed by a CouchDB restart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11385
Status
Ready
Description
This PR provides a new CouchDB view function to retrieve requests that are still open for new data.
In addition, it changes the ReqMgr2 thread that advances workflow statuses such that open requests don't go into running-closed or completed prematurely. Of course we need to support workflow abortion/rejection and force-completion.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
Requires CouchDB couchapp update (push).