Explicitly enabled verbose and abort on failure for GFAL2 plugin #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Basic tests for this have been successful. I am going to merge this one and hopefully this option will resolve the issues seen with GFAL2 based stage out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11556
Might superseed #11626
Status
ready
Description
This is a less intrusive potential fix for the GFAL2 issues seen during stage out (alternative to what is provided in #11626).
In short, it provides 2 new options to the
gfal-copycommand:-v: enable warning verbose mode--abort-on-failure: abort the whole copy process as soon as there is a failureGiven that we see an "internal" error in the gfal-copy command that does not propagate all the way to the final exit code of the command, I would expect it to be resolved with the
--abort-on-failureoption.Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None