Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute curl with svn in gitHUb actions #11639

Merged

Conversation

todor-ivanov
Copy link
Contributor

Fixes #8797
Substitutes #11638 and dmwm/CMSKubernetes#1394

Status

ready

Description

With the current PR only the broken GitHub action is fixed. Which is - the lack of sub directory structure during the docker build process for all images in our CI?CD pipeline.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14300/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks Todor.

@amaltaro amaltaro merged commit b84e1ec into dmwm:master Jul 5, 2023
@amaltaro
Copy link
Contributor

amaltaro commented Jul 5, 2023

@todor-ivanov we still have a problem with the github action workflows to create and upload docker images.
It looks like pulling data with svn worked just fine, but that had a side effect on what concerns uploading the docker image to GitLab registry.

Please have a look at this workflow log:
https://github.com/dmwm/WMCore/actions/runs/5463518658/jobs/9944338364

I found this reference for the error message:
docker/build-push-action#26

Please deal with this with the highest priority, testbed upgrade must happen today.

@todor-ivanov
Copy link
Contributor Author

Hi @amaltaro thanks for merging this PR.

Looking into the error in this very moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a WMAgent docker image
3 participants