Add campaign names support for stepchain workflows #11738
Conversation
|
Jenkins results:
|
|
Jenkins results:
|
|
Here are my test cases: Structure: Workload campaign = yes Result: Workload campaign = yes Result: Workload campaign = no Result:
Result: |
|
Jenkins results:
|
|
@amaltaro This is ready for review. |
There was a problem hiding this comment.
@khurtado these changes are looking good to me.
Can you please cover this feature in a couple StepChain unit tests as well:
https://github.com/dmwm/WMCore/blob/master/test/python/WMCore_t/WMSpec_t/StdSpecs_t/StepChain_t.py
?
Side note, when creating a pull request (or issue), please update the fields/placeholders accordingly. The initial PR description needs to be revisited.
|
@amaltaro Yes! I will add the unit tests |
|
Jenkins results:
|
|
@amaltaro The unit tests have been added. |
|
Jenkins results:
|
|
Jenkins results:
|
Fixes #11706
Status
Ready
Description
For each step, look for the campaign attribute in the workflow description and append this information in the campaign name at the task level. All step campaign names are appended to the task level campaign name with a comma. When there is no campaign attribute for a campaign, this defaults to the workload base campaign name. At the end, all unique campaigns are reported, this means if all steps have the same campaign name, this will be reported only once.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
<If it's a follow up work; or porting a fix from a different branch, please mention them here.>
External dependencies / deployment changes
<Does it require deployment changes? Does it rely on third-party libraries?>