Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry svn checkout in the CD pipeline up to 5 times #11752

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

amaltaro
Copy link
Contributor

Fixes #11748

Status

not-tested

Description

Given that svn checkout has been unstable this week, I am trying a first easy approach which is to retry it.
Retry up to 5 times, sleeping 60 seconds between retries.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 9 tests no longer failing
    • 4 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14520/artifact/artifacts/PullRequestReport.html

add double quotes

add the actual sleep 60 secs
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests deleted
    • 9 tests no longer failing
    • 5 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14522/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

And now it has the actual "sleep 60" command, which I completely missed in my previous review request. I assume it's "still" good, so I am merging this one as well.

@amaltaro amaltaro merged commit 6730908 into dmwm:master Sep 27, 2023
2 of 4 checks passed
@amaltaro
Copy link
Contributor Author

Changes provided in this PR didn't behave as expected and apparently we cannot implement a retry logic in the CD pipeline, or not in this manner, as suggested by this log snippet:

Building service: reqmgr2, with tag: 2.2.6rc1
svn: E170013: Unable to connect to a repository at URL 'https://github.com/dmwm/CMSKubernetes/trunk/docker/pypi/reqmgr2'
svn: E175002: Unexpected server error 500 'Internal Server Error' on '/dmwm/CMSKubernetes/trunk/docker/pypi/reqmgr2'
Error: Process completed with exit code 1.

extracted from today's build log: https://github.com/dmwm/WMCore/actions/runs/6627940643/job/18004052866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action failing to clone a sub-tree with svn
3 participants