Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if statement for CMS_CampaignName classad #11760

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

amaltaro
Copy link
Contributor

Fixes #11759
Part of the meta-issue: #10914

Status

ready

Description

Simple logic switch for the CMS_CampaignName job classad.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 4 warnings
    • 48 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 13 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14542/artifact/artifacts/PullRequestReport.html

@khurtado
Copy link
Contributor

Thank you for fixing this bug

@amaltaro
Copy link
Contributor Author

amaltaro commented Oct 4, 2023

I was certain that I had already merged it, well, here we go. Thanks for the review.

@amaltaro amaltaro merged commit aeaa484 into dmwm:master Oct 4, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot quote None type in SimpleCondorPlugin - CMS_CampaignName
4 participants