Deal with partial block in the parentage fix - take 2 #11779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
And this has now been tested with a couple of production workflows against testbed DBS. It works as expected. |
|
Thanks Todor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11715
Status
ready
Description
Complement to #11757
In the previous pull request, I missed one important use case, which is when a given child file has a matching parent id for some run/lumis but none for other run/lumi pairs. That means the same child file id can be used either with a valid (>0) and invalid (=-1) parent file id, e.g.
child_parent_id_list: [[3078470557, -1], [3078470557, 3078342877], ...With this pull request, we only add the
-1tuple if the child file has NO parent file ids at all, such that the DBS server can correctly count the number of children files with missing parent.Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Complement to #11757
External dependencies / deployment changes
None