-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11239: Replaced instances of logging.warn to logging.warning #11785
Fix #11239: Replaced instances of logging.warn to logging.warning #11785
Conversation
Since logging.warn is deprecated, instances of logging.warn have been replaced with logging.warning.
Jenkins results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d-ylee Dennis, thank you for creating this pull request. I have the impression we had also seen this "warn" usage in one of the test/ files, no?
4a746d6
to
bf8aae0
Compare
@amaltaro Thanks for the reminder. It looks like my search of |
Jenkins results:
|
Jenkins results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d-ylee thanks Dennis. Changes look good to me.
Just an observation, the 2nd commit contains src/* code changes as well. But this is your 1st PR in WMCore, so we are all good ;)
Fixes #11239
Status
Ready
Description
Since logging.warn is deprecated, instances of logging.warn have been replaced with logging.warning.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
N/A
External dependencies / deployment changes
No