Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11239: Replaced instances of logging.warn to logging.warning #11785

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

d-ylee
Copy link
Contributor

@d-ylee d-ylee commented Nov 3, 2023

Fixes #11239

Status

Ready

Description

Since logging.warn is deprecated, instances of logging.warn have been replaced with logging.warning.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

N/A

External dependencies / deployment changes

No

Since logging.warn is deprecated, instances of logging.warn have been
replaced with logging.warning.
@d-ylee d-ylee requested a review from amaltaro November 3, 2023 17:15
@d-ylee d-ylee assigned d-ylee and unassigned d-ylee Nov 3, 2023
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 29 warnings and errors that must be fixed
    • 9 warnings
    • 106 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 71 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14597/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-ylee Dennis, thank you for creating this pull request. I have the impression we had also seen this "warn" usage in one of the test/ files, no?

@d-ylee d-ylee force-pushed the fix_11239_replace_warn_with_warning branch from 4a746d6 to bf8aae0 Compare November 3, 2023 18:20
@d-ylee
Copy link
Contributor Author

d-ylee commented Nov 3, 2023

@amaltaro Thanks for the reminder. It looks like my search of logging.warnmissed the logger.warn in the test file. I also found a special case in Requests.py

@d-ylee d-ylee requested a review from amaltaro November 3, 2023 18:21
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 31 warnings and errors that must be fixed
    • 9 warnings
    • 183 comments to review
  • Pylint py3k check: failed
    • 2 errors and warnings that should be fixed
  • Pycodestyle check: succeeded
    • 72 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14598/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 31 warnings and errors that must be fixed
    • 11 warnings
    • 242 comments to review
  • Pylint py3k check: failed
    • 2 errors and warnings that should be fixed
  • Pycodestyle check: succeeded
    • 95 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14600/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-ylee thanks Dennis. Changes look good to me.
Just an observation, the 2nd commit contains src/* code changes as well. But this is your 1st PR in WMCore, so we are all good ;)

@amaltaro amaltaro merged commit 0ce55b3 into dmwm:master Nov 3, 2023
2 of 4 checks passed
@d-ylee d-ylee deleted the fix_11239_replace_warn_with_warning branch November 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
3 participants