Add transition attribute to MSPIleup document

[vkuznet]

Fixes #11801

Status

ready

Description

1. Provide new transition attribute to MSPileup document
2. Adjusted validation of contrainerFraction to be in (0,1] range

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

We will need to update MSPileup documents in testbed cluster

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 10 new failures
  • 1 tests added
  • 2 changes in unstable tests
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 9 warnings
  • 3 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14662/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 14 warnings
  • 18 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 5 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14664/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 14 warnings
  • 18 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 5 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14668/artifact/artifacts/PullRequestReport.html

[amaltaro]

@vkuznet Valentin, in which situation(s) we call the validate function for MSPileupObj? If it's called for every update of the document - which I think it is - then validating the timestamp to be within the last 24h is not correct. IMO that validation function should be [0, time now].

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 tests added
• Python3 Pylint check: failed
  • 4 warnings and errors that must be fixed
  • 14 warnings
  • 18 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 5 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14672/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 tests added
  • 3 changes in unstable tests
• Python3 Pylint check: failed
  • 2 warnings and errors that must be fixed
  • 14 warnings
  • 17 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 2 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14673/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 2 new failures
  • 1 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 14 warnings
  • 17 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14674/artifact/artifacts/PullRequestReport.html

[amaltaro]

@vkuznet Valentin, other than the question I left in the code, everything looks good to me. Can you please squash the commits accordingly? Did you check if the 2 failing unit tests are related to these changes?

[amaltaro]

@vkuznet Valentin, can you please also take this opportunity to update this wiki accordingly:
https://github.com/dmwm/WMCore/wiki/ReqMgr2-MicroService-Pileup

Please include the customName to the documentation as well, in case it's not there yet.

[vkuznet]

Alan, I updated the wiki too with customName and transition definitions, but we'll need to keep updating it when we'll add logic for creating them.

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 tests added
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 14 warnings
  • 17 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14680/artifact/artifacts/PullRequestReport.html

[amaltaro]

Thanks Valentin. Unit test failure is unrelated and unstable.

[amaltaro]

@vkuznet Valentin, I have just cut a new tag 2.2.6rc4. Once it's available from the CD pipeline, can you please update all of the WM services in cmsweb-testbed? Once that is completed, please announce it in our WM Team channel as well. Thanks

[vkuznet]

done