Fixed Inappropriate Logical Expression

[fabihatasneem]

Status

Ready

Description

While triaging your project, our bug-fixing tool generated the following message(s)-

In file: MathAlgos.py, the comparison of Collection length creates a logical short circuit. iCR suggested that the Collection length comparison should be done without creating a logical short circuit.

Notes

The length of a list can never be negative, hence the code block is unreachable and can safely be removed.

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

Git Commit SignOff documentation

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

NONE

External dependencies / deployment changes

NONE

[cmsdmwmbot]

Can one of the admins verify this patch?

[amaltaro]

Hi @fabihatasneem , we appreciate your contribution to the project and it looks good to me. Thank you very much!