Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace svn by git in GitHub actions #11858

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

amaltaro
Copy link
Contributor

Fixes #11748

Status

ready

Description

Deprecate svn from the github workflows and instead adopt git sparse-checkout for fetching only the relevant subfolders from the repository.

Documentation on the sparse-checkout can be found at: https://github.blog/2020-01-17-bring-your-monorepo-down-to-size-with-sparse-checkout/

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

Copy link
Contributor

@vkuznet vkuznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view it is more complicated and error prone than pure REST API. Said that there is nothing wrong with this approach, but based on previous git history git is not always backward compatible and options used in this approach may diverge in a future.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 4 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14764/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

unit test failures are unrelated.

Valentin, you have a point here. The sparse-checkout feature was added in 2021.
I would say, if we have another problem with the git approach in the coming year or two, it's probably better to adopt the curl approach, as you mentioned here: #11748 (comment)

Thank you for the prompt review!

@amaltaro amaltaro merged commit acec6f7 into dmwm:master Jan 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action failing to clone a sub-tree with svn
3 participants