Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name in log record; complement to #11879 #11908

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

amaltaro
Copy link
Contributor

Fixes #11620
Complement to #11879

Status

ready

Description

Dennis fixed this issue in this PR: #11905
but I would like to deploy it in production in the upgraded scheduled for today, so here goes a simple fix to the variable name being referenced in an important log record of the WorkQueue.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Bug fix for #11879

External dependencies / deployment changes

None

@amaltaro
Copy link
Contributor Author

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 9 warnings and errors that must be fixed
    • 1 warnings
    • 25 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14903/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro merged commit 1249c20 into dmwm:master Feb 21, 2024
3 of 4 checks passed
@amaltaro
Copy link
Contributor Author

Apologies for bypassing the review, but I wanted to have it in the production deployment in 1h from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor pileup data location in global workqueue to support partial availability
2 participants