Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetic changes for storage.json fix provided in 11869 #11917

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

amaltaro
Copy link
Contributor

Fixes #11703
Complement to #11869 (with pylint/pycodestyle/etc)

Status

ready

Description

Only aesthetic changes provided on top of #11869

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Complement to #11869

External dependencies / deployment changes

None

@amaltaro
Copy link
Contributor Author

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 2 tests deleted
    • 3 tests added
  • Python3 Pylint check: failed
    • 37 warnings and errors that must be fixed
    • 8 warnings
    • 179 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 31 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14934/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 2 tests deleted
    • 3 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 37 warnings and errors that must be fixed
    • 8 warnings
    • 179 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 31 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14935/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@khurtado khurtado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automated formatting, isn't it?

Everything looks perfect 👍

@amaltaro
Copy link
Contributor Author

Thanks, Kenyi!
Yes, most was automated via "Reformat Code" option in PyCharm. I still had to open each file and manually fix one import that we cannot delete, and replace print by logging.info.

@amaltaro amaltaro merged commit 35e53b6 into dmwm:master Feb 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abandon storage.xml in favor of storage.json for stage-in and stage-out
3 participants