Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WMCore.BossAir package to crabtaskwork #11926

Merged

Conversation

novicecpp
Copy link
Contributor

Fixes #11912

Status

Ready

Description

Add WMCore.BossAir to crabtaskwork. It is required by WMCore.WMRuntime.Bootstrap module.
This is only affects CRAB.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@novicecpp novicecpp changed the title Add WMCore.BossAir packages to crabtaskwork Add WMCore.BossAir package to crabtaskwork Mar 7, 2024
@amaltaro
Copy link
Contributor

amaltaro commented Mar 7, 2024

@novicecpp Hi Wa, apologies for not getting back to this one. These changes look good to me, but if you don't want to pull in all the BossAir python subpackage, you could instead change the modules by adding 'WMCore.BossAir.Plugins.BasePlugin.py', 'WMCore.BossAir.Plugins.__init__.py'

Just let me know your preference please.

@novicecpp
Copy link
Contributor Author

Hi Alan, no worry and thanks for looking at it.

Less is better in my opinion. But let me test it first.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 28 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14953/artifact/artifacts/PullRequestReport.html

@novicecpp
Copy link
Contributor Author

Hi again,
I have applied your suggestion and ran the test. The test jobs were running without issue (Task View in Grafana). Thanks a lot.

BTW, do I need to squash the commit?

@amaltaro
Copy link
Contributor

amaltaro commented Mar 7, 2024

Awesome! Yes, please squash them and make a review request through the Reviewers option, on the right/top side.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 28 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14954/artifact/artifacts/PullRequestReport.html

@novicecpp novicecpp force-pushed the fix_crabtaskworker_new_dependencies branch from 6c7af45 to 89cb949 Compare March 7, 2024 14:49
@novicecpp
Copy link
Contributor Author

I have squashed it, but I do not have permission to make a review request.

@amaltaro
Copy link
Contributor

amaltaro commented Mar 7, 2024

@novicecpp I sent you an invite to join the WMCore-Contributors team. Once you join it, can you please try the review request again? Thanks

@novicecpp novicecpp requested a review from amaltaro March 7, 2024 15:11
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 28 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14955/artifact/artifacts/PullRequestReport.html

@novicecpp
Copy link
Contributor Author

Done.
Thanks.

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wa!

@amaltaro amaltaro merged commit 7bb1575 into dmwm:master Mar 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'WMCore.BossAir' error when running CRAB jobs with WMCore==2.3.1rc3
3 participants