Fix last digit wrap in customDID sequence

[vkuznet]

Fixes #11736

Status

ready

Description

I found that current algorithm in customDID function creates wrong sequence number when last digit is more than 10 and lasts with number 9, i.e. 19, 1119, 29, etc. This leads to non-sequential sequence number wraps, e.g. (taken from cmsweb-testbed):

    {
      "containerFraction": 1.0,
      "customDID": "/hasan-test10-Neutrino_E-10_gun/Run3Summer21PrePremix-120X_mcRun3_2021_realistic_v6-v2/PREMIX-V19",
      "updateTime": 1709642777,
      "DN": ""
    },
    {
      "containerFraction": 1.0,
      "customDID": "/hasan-test10-Neutrino_E-10_gun/Run3Summer21PrePremix-120X_mcRun3_2021_realistic_v6-v2/PREMIX-V110",
      "updateTime": 1709643280,
      "DN": "xxx"
    },

Please see that transition record went from -V19 to -V110. This PR fixes this issue.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 tests no longer failing
• Python3 Pylint check: succeeded
  • 7 warnings
  • 3 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 1 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14992/artifact/artifacts/PullRequestReport.html

[amaltaro]

Please test V99 and V100 as well

[vkuznet]

Please test V99 and V100 as well

I added new unit test for this use-case too, it runs fine in my local area, but jenkins are triggered again.

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 1 changes in unstable tests
• Python3 Pylint check: succeeded
  • 7 warnings
  • 3 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 2 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14993/artifact/artifacts/PullRequestReport.html

[amaltaro]

Looks good to me, please squash commits accordingly.

[vkuznet]

commits are squashed

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 1 changes in unstable tests
• Python3 Pylint check: succeeded
  • 7 warnings
  • 3 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 1 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14994/artifact/artifacts/PullRequestReport.html

[amaltaro]

Thanks Valentin!