Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for Spec generation with alphanumerical data tiers #11951

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

germanfgv
Copy link
Contributor

Fixes #11930

Status

ready

Description

While the previous changes merged in #11931 where enough to accept the final datasets and lfn of files with numbers in their data tier, it turns out workflow creation fails in the process , as the intermediate regexp of lexicon weren't updated. This fixes that.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

#11931

External dependencies / deployment changes

No

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 94 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 84 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14996/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @germanfgv

It looks good to me

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this fix, German.

@amaltaro amaltaro merged commit 4bc4a58 into dmwm:master Mar 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants