Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in DataTier fields in all regular expressions #11962

Conversation

todor-ivanov
Copy link
Contributor

@todor-ivanov todor-ivanov commented Apr 9, 2024

Fixes #11961

Status

ready

Description

With the current change we allow numbers at the data tier fields in all possible regular expressions defined at the WMCore lexicon.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

DBS prod: services_config#249
DBS preprod: services_config#246 + services_config#248

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 95 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 85 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15006/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks Todor.

@amaltaro amaltaro merged commit fec0e04 into dmwm:master Apr 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Data Tier numbers in all fields at the lexicon
3 participants