Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies & code cleanup #38

Merged
merged 1 commit into from
Dec 19, 2015
Merged

Remove unused dependencies & code cleanup #38

merged 1 commit into from
Dec 19, 2015

Conversation

kasimi
Copy link
Contributor

@kasimi kasimi commented Dec 19, 2015

Sorry, this has gotten a little out of control. 😇

While removing some unused dependencies from the services.yml and adjusting the constructors, I started going through the whole classes and fixed the formatting and other minor inconsistency. So, apart from syntax changes (which, again, cause these GitHub diffs to be extremely bloated), I fixed the following issues:

  1. SEVERE: Fixed unauthorized access and XSRF vulnerability when adding messages
  2. When unauthorized access is detected, the non-existing language variable MCHAT_ERROR_FORBIDDEN was used. Changed to MCHAT_NOACCESS
  3. Fixed bug where the custom chat page displayed who is chatting when mChat is disabled
  4. Using event core.display_custom_bbcodes_modify_sql to filter forbidden BBCodes and removed copy-pasted code from functions_mchat.php
  5. Switched from deprecated get_user_avatar() to phpbb_get_user_avatar()
  6. Save an SQL query when receiving an edit request from a user with moderator permissions

dmzx added a commit that referenced this pull request Dec 19, 2015
Remove unused dependencies & code cleanup
@dmzx dmzx merged commit 3bd4708 into dmzx:master Dec 19, 2015
@dmzx
Copy link
Owner

dmzx commented Dec 19, 2015

Wow thanks again for your time!

@kasimi
Copy link
Contributor Author

kasimi commented Dec 19, 2015

My pleasure. What about this one failed check? I'm not familiar with Travis and I don't understand what the Travis build log is telling me.

@kasimi
Copy link
Contributor Author

kasimi commented Dec 19, 2015

Oh, you merged it already. Never mind. 😇

@dmzx
Copy link
Owner

dmzx commented Dec 19, 2015

A no problem just solved it's ok now

@kasimi kasimi deleted the php-cleanup branch December 19, 2015 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants