Remove unused dependencies & code cleanup #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this has gotten a little out of control. 😇
While removing some unused dependencies from the
services.yml
and adjusting the constructors, I started going through the whole classes and fixed the formatting and other minor inconsistency. So, apart from syntax changes (which, again, cause these GitHub diffs to be extremely bloated), I fixed the following issues:MCHAT_ERROR_FORBIDDEN
was used. Changed toMCHAT_NOACCESS
core.display_custom_bbcodes_modify_sql
to filter forbidden BBCodes and removed copy-pasted code fromfunctions_mchat.php
get_user_avatar()
tophpbb_get_user_avatar()
edit
request from a user with moderator permissions