Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all Harmony decoding #124

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix all Harmony decoding #124

merged 1 commit into from
Oct 9, 2019

Conversation

DJBen
Copy link
Collaborator

@DJBen DJBen commented Oct 9, 2019

LilyPondTest suite now has 59 failures.

@codecov-io
Copy link

Codecov Report

Merging #124 into latest will increase coverage by 5.47%.
The diff coverage is 88.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #124      +/-   ##
==========================================
+ Coverage    52.2%   57.67%   +5.47%     
==========================================
  Files         218      218              
  Lines        2632     2800     +168     
==========================================
+ Hits         1374     1615     +241     
+ Misses       1258     1185      -73
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Ornaments.swift 100% <ø> (ø) ⬆️
Sources/MusicXML/Complex Types/Root.swift 100% <ø> (+100%) ⬆️
Sources/MusicXML/Complex Types/Bass.swift 100% <ø> (+100%) ⬆️
Sources/MusicXML/Complex Types/Degree.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/BassAlter.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/BassStep.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/DegreeAlter.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/DegreeValue.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/Slide.swift 100% <100%> (+100%) ⬆️
Sources/MusicXML/Complex Types/RootStep.swift 100% <100%> (+100%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e22f50...91dedc8. Read the comment docs.

@jsbean
Copy link
Member

jsbean commented Oct 9, 2019

🙌

@jsbean jsbean merged commit 5843d08 into dn-m:latest Oct 9, 2019
@DJBen DJBen deleted the sihao/fix-harmony branch October 10, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants