Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ContiguousSegmentCollection #154

Merged
merged 85 commits into from
Aug 27, 2018
Merged

Implement ContiguousSegmentCollection #154

merged 85 commits into from
Aug 27, 2018

Conversation

jsbean
Copy link
Member

@jsbean jsbean commented Aug 23, 2018

This PR pulls down the similar set of protocols in dn-m/Music/Duration used for Meter.Collection and Tempo.Interpolation.Collection and refactors it into a generic struct.

Tests added.

@jsbean
Hack implementation of ContiguousSegmentCollection
40cf44c
@jsbean
Add tests
1011a16
@jsbean
Generate Linux main
eccbe27
@jsbean
Streamline example struct
05c9a63
@jsbean
Implement normalized
ede262e
@jsbean
Add doc comment
fdb6f1d
@jsbean
Implement offsetBy
fc8ce7c
@jsbean
Improve quality of implementation of indexOfElement(containing:for:)
5dde00e
@jsbean
Remove trash
b58d361
@jsbean
Implement indices(containingBoundsOf:)
06d7d87
@jsbean
Refine naming
f09643d
@jsbean
Refine range normalization
5b5e84b
@jsbean
Tidy up
97d0b19
@jsbean
Clean up trash
cab4293
@jsbean
Update semantics such that offsets are maintained in fragments
0cb8e40
@jsbean
Refine innards management
2438b05
@jsbean
Tidy
187810d
@jsbean
Refine generics
9adb746
@jsbean
Add MARK
1b8bb78
@jsbean
Refine order
54d9c24
@jsbean
Remove trash
0a6dfff
@jsbean
Remove trash
f10725f
@jsbean
Remove unused code
442cdfb
@jsbean
Remove unused code
8f66566
@jsbean
Add doc comment
9d276bd
@jsbean
Add doc comments
77d2da6
@jsbean
Add MeasuredFragmentable
b896d2a
@jsbean
Tidy up
6226665
@jsbean
Break out FragmentProtocol / MeasuredFragment
491e940
@jsbean
Pull apart protocol nest
5550ce8
@jsbean
Clean up trash
3ee8ca1
@jsbean
Clean up trash
388592e
@jsbean
Remove unused code
4530eb1
@jsbean
Remove dead code
1dfe005
@jsbean
Pass on Metric associatedtype
d50b351
@jsbean
Refine doc comments
73e62a7
@jsbean
Whitespace
45f2899
@jsbean
Inject searchRange into index binary search
dea6861
@jsbean
Only search startIndex ..< count once the startIndex has been found
470e9b9
@jsbean
Refine IntervallicFragmentable organization, doc comments
10ed34e
@jsbean
Remove redundant typealias decl
e75bd08
@jsbean
Remove redundant typealias decl
ba9a8e3
@jsbean
Hide Fragment.Segments and related init, add public inits
8ee3702
@jsbean
Put Equatable conformance up top for test
5780bf8
@jsbean
Generate Linux main
75442c8
@jsbean
Add default .zero for Fragment init
26e5e7a
@jsbean
Use ArraySlice instead of Array for storing innards
bb14194
@jsbean
Refactor Segments enum away
d8781c5
@jsbean
Work towards fragment of fragment
6f9b258
@jsbean
Add failing tests for fragment.fragment
03f050e
@jsbean
Remove bodyOffset local var
c0e1dad
@jsbean
Clean up storage of Segments and Fragments
ee6b671
@jsbean
Implement IntervallicFragmentable for ContiguousSegmentCollection.Fra…
791d4f0 
…gment
@jsbean
Generate Linux main
af68b20
@jsbean
Remove print statement
327ba11
@jsbean
Improve quality of implementation
668d5a3
@jsbean
Refine naming
cd43fc3
@jsbean jsbean merged commit b179331 into master Aug 27, 2018
@jsbean jsbean deleted the segments branch September 29, 2018 14:25
@jsbean jsbean mentioned this pull request Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsbean