Fix nested archives in CI artifacts #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`actions/upload-artifact@v2` zips the given path, which is already a zip, resulting in nested zips in the artifacts. We can have `upload-artifact` run on the results instead, which requires moving the cleaning to the next build and placing the uploads in-between as each build was removing its output aside fromits created zip.
ElektroKill
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/upload-artifact@v2zips the given path, which is already a zip, resulting in nested zips in the artifacts. We can haveupload-artifactrun on the results instead, which requires moving the cleaning to thenext build and placing the uploads in-between as each build was removing all of its output aside from its created zip.