Add custom interaction matching. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interactions (recorded request/response pairs) were only matched according to request method and URL during replay. This limits the usefulness of go-vcr for testing HTTP requests because the interesting state is often in the headers or body. For example, a idiomatic PUT action in a REST API may have the same URL but respond differently based on the body. This commit matches requests to interactions using a Matcher function. Users of the go-vcr library can define and use custom matchers in their tests by setting the matcher on the recorder with SetMatcher.
Since the recorder package imports cassette, the import paths were changed to another fork for testing. This commit restores the imports to the original repository for a cleaner merge.
|
Thanks! |
dougnukem
pushed a commit
to dougnukem/go-vcr
that referenced
this pull request
Oct 20, 2016
Add custom interaction matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactions (recorded request/response pairs) were only matched
according to request method and URL during replay. This limits
the usefulness of go-vcr for testing HTTP requests because the
interesting state is often in the headers or body. For example, a
idiomatic PUT action in a REST API may have the same URL but respond
differently based on the body.
This PR matches requests to interactions using a Matcher function.
Users of the go-vcr library can define and use custom matchers in
their tests by setting the matcher on the recorder with SetMatcher.