Bug fix: Remove unused sqlite3 dependency #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnbert
pushed a commit
that referenced
this pull request
Sep 6, 2013
Bug fix: Remove unused sqlite3 dependency
|
You're right! Thanks for the pull request. I had SQLite as a dependency originally there for RPM support but did inline XML instead - yum is confusing and weird :) Let me know if you'd like new features or anything, I'm always looking to add in more utilities/functionality into PRM. |
|
oh and I've published the new gem to Rubygems.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this isn't used anywhere in the code base, and it means my apt servers need the sqlite3 development packages to install the sqlite3 gem or prm install fails.
I did a little grepping for sqlite and had a look if any gems depended on it in the Gemfile.lock but found nothing.
I've bumped the patch version.
If it is used and I've misdiagnosed this, feel free to close and delete :)