Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Eufemia): enhance CSS version check for dnb-core-style #3522

Merged
merged 4 commits into from
May 8, 2024

Conversation

snorrekim
Copy link
Contributor

@snorrekim snorrekim commented May 6, 2024

  • Also check the .dnb-core-style element if version is not found on body
  • warning instead of error if version is unknown
  • Explain that unknown might be caused by lazy loading or a version older than "10.25.0"
  • Add a .js import for theme basis and update documentation for css importing
  • Fix .js import of eiendom theme

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:02am

Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker changed the title chore(Eufemia): test css version in dnb-core-style fix(Eufemia): enhance CSS version ckeck for dnb-core-style May 6, 2024
@snorrekim snorrekim marked this pull request as draft May 7, 2024 07:49
@snorrekim snorrekim changed the title fix(Eufemia): enhance CSS version ckeck for dnb-core-style fix(Eufemia): enhance CSS version check for dnb-core-style May 7, 2024
@snorrekim snorrekim force-pushed the chore/eufemia-css-version-test branch from b0833a5 to fab3333 Compare May 7, 2024 09:46
@snorrekim snorrekim force-pushed the chore/eufemia-css-version-test branch from fab3333 to e94df97 Compare May 7, 2024 09:56
@snorrekim snorrekim marked this pull request as ready for review May 8, 2024 10:21
@snorrekim snorrekim requested a review from tujoworker May 8, 2024 10:21
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🙏

@snorrekim snorrekim merged commit eac2bcf into main May 8, 2024
10 checks passed
@snorrekim snorrekim deleted the chore/eufemia-css-version-test branch May 8, 2024 11:15
tujoworker pushed a commit that referenced this pull request May 8, 2024
## [10.30.0](v10.29.0...v10.30.0) (2024-05-08)

### 🐛 Bug Fixes

* **Eufemia:** enhance CSS version check for dnb-core-style ([#3522](#3522)) ([eac2bcf](eac2bcf))

### ✨ Features

* **forms:** add `fieldPropsWhenHidden` to Visibility ([#3539](#3539)) ([5d8d6db](5d8d6db))
* **forms:** add `Form.FieldProps` provider to forward a certain props to all fields ([#3536](#3536)) ([0f875bd](0f875bd))
* **forms:** add `locale`, `translations`, `required` and `disabled` prop support to `Form.Handler` ([#3537](#3537)) ([b95f215](b95f215))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants