feat(forms): add Form.FieldProps provider to forward a certain props to all fields
#3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tujoworker
force-pushed
the
feat/field-props
branch
from
8a5c0aa
to
7bbf382
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
force-pushed
the
feat/field-props
branch
from
7bbf382
to
6e4a1f2
Compare
joakbjerk
approved these changes
May 8, 2024
| @@ -0,0 +1,26 @@ | |||
| --- | |||
| title: 'FieldProps' | |||
| description: '`Form.FieldProps` is a provider for forwarding fields properties, such as `required` or `disabld` to all nested field components.' | |||
There was a problem hiding this comment.
Suggested change
| description: '`Form.FieldProps` is a provider for forwarding fields properties, such as `required` or `disabld` to all nested field components.' | |
| description: '`Form.FieldProps` is a provider for forwarding field properties, such as `required` or `disabld` to all nested field components.' |
|
|
||
| ## Description | ||
|
|
||
| `Form.FieldProps` is a provider for forwarding fields properties, such as `required` or `disabld` to all nested field components. |
There was a problem hiding this comment.
Suggested change
| `Form.FieldProps` is a provider for forwarding fields properties, such as `required` or `disabld` to all nested field components. | |
| `Form.FieldProps` is a provider for forwarding field properties, such as `required` or `disabld` to all nested field components. |
| const context = reduceContext(contexts) | ||
| return Object.entries(context).reduce((acc, [key, value]) => { | ||
| if (!(props && Object.prototype.hasOwnProperty.call(props, key))) { | ||
| // if (key !== 'disabled') { |
There was a problem hiding this comment.
We should probably remove these comments?
tujoworker
pushed a commit
that referenced
this pull request
May 8, 2024
## [10.30.0](v10.29.0...v10.30.0) (2024-05-08) ### 🐛 Bug Fixes * **Eufemia:** enhance CSS version check for dnb-core-style ([#3522](#3522)) ([eac2bcf](eac2bcf)) ### ✨ Features * **forms:** add `fieldPropsWhenHidden` to Visibility ([#3539](#3539)) ([5d8d6db](5d8d6db)) * **forms:** add `Form.FieldProps` provider to forward a certain props to all fields ([#3536](#3536)) ([0f875bd](0f875bd)) * **forms:** add `locale`, `translations`, `required` and `disabled` prop support to `Form.Handler` ([#3537](#3537)) ([b95f215](b95f215))
|
🎉 This PR is included in version 10.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.