Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): add locale, translations, required and disabled prop support to Form.Handler #3537

Merged
merged 4 commits into from
May 8, 2024

Conversation

tujoworker
Copy link
Member

No description provided.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 9:52am

@tujoworker tujoworker requested a review from joakbjerk May 8, 2024 07:50
Copy link

codesandbox-ci bot commented May 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to have a separation from locale and translations by renaming locales to translation 👍

The code looks correct, but I cant se the changes in translations based on locale when testing in the portal Ignore the brainfart

@tujoworker tujoworker changed the title feat(forms): add locale, required and disabled prop support to Form.Handler feat(forms): add locale, translations, required and disabled prop support to Form.Handler May 8, 2024
@tujoworker tujoworker merged commit b95f215 into main May 8, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/field-props-handler branch May 8, 2024 10:18
tujoworker pushed a commit that referenced this pull request May 8, 2024
## [10.30.0](v10.29.0...v10.30.0) (2024-05-08)

### 🐛 Bug Fixes

* **Eufemia:** enhance CSS version check for dnb-core-style ([#3522](#3522)) ([eac2bcf](eac2bcf))

### ✨ Features

* **forms:** add `fieldPropsWhenHidden` to Visibility ([#3539](#3539)) ([5d8d6db](5d8d6db))
* **forms:** add `Form.FieldProps` provider to forward a certain props to all fields ([#3536](#3536)) ([0f875bd](0f875bd))
* **forms:** add `locale`, `translations`, `required` and `disabled` prop support to `Form.Handler` ([#3537](#3537)) ([b95f215](b95f215))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants