Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple nodes #3

Merged
merged 17 commits into from
Jun 27, 2023
Merged

Implement simple nodes #3

merged 17 commits into from
Jun 27, 2023

Conversation

dnnrly
Copy link
Owner

@dnnrly dnnrly commented Jun 16, 2023

Description

  • As a user, I would like to specify a single node

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +46.81 🎉

Comparison is base (7ee6a8d) 40.00% compared to head (f823031) 86.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
+ Coverage   40.00%   86.81%   +46.81%     
===========================================
  Files           2        2               
  Lines          10       91       +81     
===========================================
+ Hits            4       79       +75     
- Misses          5        8        +3     
- Partials        1        4        +3     
Impacted Files Coverage Δ
cmd/layli/main.go 83.33% <82.85%> (-16.67%) ⬇️
layli.go 89.09% <89.09%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- And fix some of the developer instructions and badges.
@dnnrly dnnrly marked this pull request as draft June 17, 2023 07:58
@dnnrly dnnrly marked this pull request as ready for review June 27, 2023 22:11
@dnnrly dnnrly merged commit b17feff into master Jun 27, 2023
@dnnrly dnnrly deleted the feature/simple-nodes branch June 27, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant