Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed shared lib. module name clash #11

Merged
merged 1 commit into from
May 28, 2014
Merged

Conversation

kashif
Copy link
Contributor

@kashif kashif commented May 27, 2014

No description provided.

@kashif
Copy link
Contributor Author

kashif commented May 27, 2014

@invisibleroads can you try this fix? thanks!

@invisibleroads
Copy link

@kashif

I can confirm that your fix now runs successfully on ec2.

However, the cmake modifications, while successful on ec2, seem to fail for older graphics cards. I created a new issue here #12

@dnouri
Copy link
Owner

dnouri commented May 28, 2014

Makes me wonder what was wrong with the original name of the .so file!

dnouri added a commit that referenced this pull request May 28, 2014
fixed shared lib. module name clash
@dnouri dnouri merged commit 9513e58 into dnouri:master May 28, 2014
@kashif
Copy link
Contributor Author

kashif commented May 28, 2014

@dnouri yes it was my fault, I should not have changed it, I was looking at the __import__() method and trying to get Cmake to generate the shared file name without the "lib" prefix and got rid of the underscore in the name without realising that there was a clash... 😊 Thanks for merging!

@kashif kashif deleted the module-name branch May 28, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants