Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Checking of use_label_encoder #38

Closed
cancan101 opened this issue Feb 8, 2015 · 0 comments
Closed

Inconsistent Checking of use_label_encoder #38

cancan101 opened this issue Feb 8, 2015 · 0 comments

Comments

@cancan101
Copy link
Contributor

Here the predicate is not self.regression and self.use_label_encoder whereas here it is just: self.use_label_encoder.

Having self.regression==True and self.use_label_encoder==True should just be an assertion error in the constructor which would simplify checking use_label_encoder.
@dnouri dnouri closed this as completed in 6d33094 Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cancan101