Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop 0.68.0 #173

Closed
wants to merge 6 commits into from
Closed

Conversation

jodosha
Copy link
Contributor

@jodosha jodosha commented May 1, 2019

No description provided.

@jodosha jodosha added enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. labels May 1, 2019
@jodosha jodosha self-assigned this May 1, 2019
@jodosha jodosha removed the ready-for-review Pull requests that are ready to be reviewed by other team members. label May 1, 2019
@san983
Copy link
Member

san983 commented May 17, 2019

@jodosha Shouldn't we deprecate < MRI 2.3 support since actually those rubies aren't supported anymore? (and that will make this build green again)

@jodosha
Copy link
Contributor Author

jodosha commented May 20, 2019

@san983 I agree.

@jodosha
Copy link
Contributor Author

jodosha commented May 23, 2019

In order to support Rubocop 0.68+ we need to no longer support < MRI 2.3, which is a breaking change.

In the meantime a new version of Rubocop is out, it makes no sense to keep this open.

@jodosha jodosha closed this May 23, 2019
@jodosha jodosha deleted the enhancement/upgrade-rubocop-0-68-0 branch May 23, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants