Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from 0.83.0 to 0.84.0 #181

Merged
merged 1 commit into from
May 21, 2020
Merged

Update rubocop requirement from 0.83.0 to 0.84.0 #181

merged 1 commit into from
May 21, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.84

New features

  • #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. (@marcandre)
  • #7950: Add new Lint/DeprecatedOpenSSLConstant cop. (@bdewater)
  • #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. (@koic)
  • #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. (@marcandre)

Bug fixes

  • #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. (@koic)
  • #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. (@koic)
  • #7967: Style/SlicingWithRange cop now supports any expression as its first index. (@zverok)
  • #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. (@koic)
  • #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. (@jonas054)
  • #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. (@koic)
  • #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. (@koic)

Changes

  • #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. (@koic)
  • #7959: Change enforced style to conditionals for Style/AndOr. (@koic)
  • #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. (@koic)
Changelog

Sourced from rubocop's changelog.

0.84.0 (2020-05-21)

New features

  • #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. ([@marcandre][])
  • #7950: Add new Lint/DeprecatedOpenSSLConstant cop. ([@bdewater][])
  • #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. ([@koic][])
  • #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. ([@marcandre][])

Bug fixes

  • #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. ([@koic][])
  • #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. ([@koic][])
  • #7967: Style/SlicingWithRange cop now supports any expression as its first index. ([@zverok][])
  • #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. ([@koic][])
  • #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. ([@jonas054][])
  • #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. ([@koic][])
  • #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. ([@koic][])

Changes

  • #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. ([@koic][])
  • #7959: Change enforced style to conditionals for Style/AndOr. ([@koic][])
  • #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. ([@koic][])

0.83.0 (2020-05-11)

New features

  • #7951: Include rakefile file by default. ([@jethrodaniel][])
  • #7921: Add new Style/SlicingWithRange cop. ([@zverok][])
  • #7895: Include .simplecov file by default. ([@robotdana][])
  • #7916: Support autocorrection for Lint/AmbiguousRegexpLiteral. ([@koic][])
  • #7917: Support autocorrection for Lint/UselessAccessModifier. ([@koic][])
  • #595: Add ERB pre-processing for configuration files. ([@jonas054][])
  • #7918: Support autocorrection for Lint/AmbiguousOperator. ([@koic][])
  • #7937: Support autocorrection for Style/IfWithSemicolon. ([@koic][])
  • #3696: Add AllowComments option to Lint/EmptyWhen cop. ([@koic][])
  • #7910: Support autocorrection for Lint/ParenthesesAsGroupedExpression. ([@koic][])
  • #7925: Support autocorrection for Layout/ConditionPosition. ([@koic][])
  • #7934: Support autocorrection for Lint/EnsureReturn. ([@koic][])
  • #7922: Add new Layout/EmptyLineAroundAttributeAccessor cop. ([@koic][])

Bug fixes

  • #7929: Fix Style/FrozenStringLiteralComment to accept frozen_string_literal anywhere in leading comment lines. ([@jeffcarbs][])
  • #7882: Fix Style/CaseEquality when AllowOnConstant is true and the method receiver is implicit. ([@rafaelfranca][])
  • #7790: Fix --parallel and --ignore-parent-exclusion combination. ([@jonas054][])
  • #7881: Fix --parallel and --force-default-config combination. ([@jonas054][])
  • #7635: Fix a false positive for Style/MultilineWhenThen when then required for a body of when is used. ([@koic][])
... (truncated)
Commits
  • 10a6f91 Fix the release notes
  • d7bfd36 Cut 0.84
  • 119d695 Add doc for disabling comment style
  • 82ded12 [Fix #7993] Fix a false positive for Migration/DepartmentName
  • 2a57489 Add a .dir-locals.el
  • c7fe5da Remove unneeded let for specs using :config shared environment
  • 3c91822 Refactor config shared context. Simplify some specs.
  • 4d694e3 Spec: remove trailing whitespace
  • 2e8f013 Lint/SuppressedException: Explicit AllowComments config in spec
  • 36d3e30 Lint/EmptyWhen Add explicit config that is differing from default #7999
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Update rubocop requirement from 0.83.0 to 0.84.0
54d5870 
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added backlog-dependencies Automation to assign this issue to the Dependencies backlog. dependencies Pull requests that update a dependency file. task labels May 21, 2020
duduribeiro
duduribeiro approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked fine 👍

@duduribeiro duduribeiro merged commit 9428325 into master May 21, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.84.0 branch May 21, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duduribeiro duduribeiro duduribeiro approved these changes

Assignees
No one assigned
Labels
backlog-dependencies Automation to assign this issue to the Dependencies backlog. dependencies Pull requests that update a dependency file. task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duduribeiro