Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from 0.93.1 to 1.0.0 #208

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update rubocop requirement from 0.93.1 to 1.0.0 #208

merged 1 commit into from
Oct 21, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.0

The first stable RuboCop release ever is finally here! You can read more about this special release here.

New features

  • #7944: Add MaxUnannotatedPlaceholdersAllowed option to Style/FormatStringToken cop. (@Tietew)
  • #8379: Handle redundant parentheses around an interpolated expression for Style/RedundantParentheses cop. (@fatkodima)

Bug fixes

  • #8892: Fix an error for Style/StringConcatenation when correcting nested concatenable parts. (@fatkodima)
  • #8781: Fix handling of comments in Style/SafeNavigation autocorrection. (@dvandersluis)
  • #8907: Fix an incorrect auto-correct for Layout/ClassStructure when heredoc constant is defined after public method. (@koic)
  • #8889: Cops can use new after_<type> callbacks (only for nodes that may have children nodes, like :send and unlike :sym). (@marcandre)
  • #8906: Fix a false positive for Layout/SpaceAroundOperators when upward alignment. (@koic)
  • #8585: Fix false positive in Style/RedundantSelf cop with nested self access. (@marcotc)

Changes

  • #8882: (Potentially breaking) RuboCop assumes that Cop classes do not define new on_<type> methods at runtime (e.g. via extend in initialize). (@marcandre)
  • #7966: (Breaking) Enable all pending cops for RuboCop 1.0. (@koic)
  • #8490: (Breaking) Change logic for cop department name computation. Cops inside deep namespaces (5 or more levels deep) now belong to departments with names that are calculated by joining module names starting from the third one with slashes as separators. For example, cop Rubocop::Cop::Foo::Bar::Baz now belongs to Foo/Bar department (previously it was Bar). (@dsavochkin)
  • #8692: Default changed to disallow Layout/TrailingWhitespace in heredoc. (@marcandre)
  • #8894: Make Security/Open aware of URI.open. (@koic)
  • #8901: Fix false positive for Naming/BinaryOperatorParameterName when defining =~. (@zajn)
  • #8908: Show extension cop versions when using --verbose-version option. (@koic)
Changelog

Sourced from rubocop's changelog.

1.0.0 (2020-10-21)

New features

  • #7944: Add MaxUnannotatedPlaceholdersAllowed option to Style/FormatStringToken cop. ([@Tietew][])
  • #8379: Handle redundant parentheses around an interpolated expression for Style/RedundantParentheses cop. ([@fatkodima][])

Bug fixes

  • #8892: Fix an error for Style/StringConcatenation when correcting nested concatenable parts. ([@fatkodima][])
  • #8781: Fix handling of comments in Style/SafeNavigation autocorrection. ([@dvandersluis][])
  • #8907: Fix an incorrect auto-correct for Layout/ClassStructure when heredoc constant is defined after public method. ([@koic][])
  • #8889: Cops can use new after_<type> callbacks (only for nodes that may have children nodes, like :send and unlike :sym). ([@marcandre][])
  • #8906: Fix a false positive for Layout/SpaceAroundOperators when upward alignment. ([@koic][])
  • #8585: Fix false positive in Style/RedundantSelf cop with nested self access. ([@marcotc][])

Changes

  • #8882: (Potentially breaking) RuboCop assumes that Cop classes do not define new on_<type> methods at runtime (e.g. via extend in initialize). ([@marcandre][])
  • #7966: (Breaking) Enable all pending cops for RuboCop 1.0. ([@koic][])
  • #8490: (Breaking) Change logic for cop department name computation. Cops inside deep namespaces (5 or more levels deep) now belong to departments with names that are calculated by joining module names starting from the third one with slashes as separators. For example, cop Rubocop::Cop::Foo::Bar::Baz now belongs to Foo/Bar department (previously it was Bar). ([@dsavochkin][])
  • #8692: Default changed to disallow Layout/TrailingWhitespace in heredoc. ([@marcandre][])
  • #8894: Make Security/Open aware of URI.open. ([@koic][])
  • #8901: Fix false positive for Naming/BinaryOperatorParameterName when defining =~. ([@zajn][])
  • #8908: Show extension cop versions when using --verbose-version option. ([@koic][])

0.93.1 (2020-10-12)

Bug fixes

  • #8782: Fix incorrect autocorrection for Style/TernaryParentheses with defined?. ([@dvandersluis][])
  • #8867: Rework Lint/RedundantSafeNavigation to be more safe. ([@fatkodima][])
  • #8864: Fix false positive for Style/RedundantBegin with a postfix while or until. ([@dvandersluis][])
  • #8869: Fix a false positive for Style/RedundantBegin when using begin for or assignment and method call. ([@koic][])
  • #8862: Fix an error for Lint/AmbiguousRegexpLiteral when using regexp without method calls in nested structure. ([@koic][])
  • #8872: Fix an error for Metrics/ClassLength when multiple assignments to constants. ([@koic][])
  • #8871: Fix a false positive for Style/RedundantBegin when using begin for method argument or part of conditions. ([@koic][])
  • #8875: Fix an incorrect auto-correct for Style/ClassEqualityComparison when comparing class name. ([@koic][])
  • #8880: Fix an error for Style/ClassLength when overlapping constant assignments. ([@koic][])

0.93.0 (2020-10-08)

New features

  • #8796: Add new Lint/HashCompareByIdentity cop. ([@fatkodima][])
  • #8833: Add new Style/ClassEqualityComparison cop. ([@fatkodima][])
  • #8668: Add new Lint/RedundantSafeNavigation cop. ([@fatkodima][])
  • #8842: Add notification about cache being used to debug mode. ([@hatkyinc2][])
  • #8822: Make Style/RedundantBegin aware of begin without rescue or ensure. ([@koic][])
Commits
  • f74c118 Cut RuboCop 1.0!!!
  • 8245906 Move a changelog entry
  • 89c9628 Fix false positive in Style/RedundantSelf cop with nested self access (#8...
  • b4873b7 Merge pull request #8911 from koic/fix_an_error_when_occurring_cop_error
  • 4673957 Fix a false positive for Layout/SpaceAroundOperators
  • 98e1021 Fix an error when ocurring cop error
  • e0713ad Merge pull request #8908 from koic/add_extension_versions_when_using_verbose_...
  • 96d2809 Show extension cop versions when using --verbose-version option
  • def3600 Add on_after_\<type> callbacks
  • a6dd18c Fix an incorrect auto-correct for Layout/ClassStructure
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Update rubocop requirement from 0.93.1 to 1.0.0
524803f 
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.93.1...v1.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added backlog-dependencies Automation to assign this issue to the Dependencies backlog. dependencies Pull requests that update a dependency file. task labels Oct 21, 2020
@san983 san983 self-assigned this Oct 21, 2020
@san983 san983 merged commit 173dff8 into main Oct 21, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-1.0.0 branch October 21, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@san983 san983 san983 approved these changes

Assignees

@san983 san983

Labels
backlog-dependencies Automation to assign this issue to the Dependencies backlog. dependencies Pull requests that update a dependency file. task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@san983