-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth authentication #66
Conversation
@weppos not sure what's the role of The |
I am having second thoughts against removing I'll leave them there for now and we can go back to them before closing this PR. |
@jacegu |
I'd like to have the knowledge of what endpoint to hit to make the OAuth login in the client itself. I think it's convenient as a client user to have it there... It would be something similar to (extracted from an spike): def authorize_url
"#{@url}:#{@port}/oauth/authorize?client_id=#{@client_id}&response_type=code&state=1234567"
end @weppos how do you feel about it? |
Yes, it may be useful. But I have to ask you to hold off until the Oauth is properly documented and completed. The OAuth controller in fact is still incomplete, and it may result into an incomplete or inefficient implementation in the client. |
With the changes in place you can see this working locally: $: << 'lib'
require 'dnsimple'
client = Dnsimple::Client.new(oauth_access_token: "XXX")
puts client.get("/v2/1/domains") |
Support for OAuth-based authentication in API v2