Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GenericDecimal::default() #40

Closed
wants to merge 1 commit into from
Closed

Add GenericDecimal::default() #40

wants to merge 1 commit into from

Conversation

jgarvin
Copy link

@jgarvin jgarvin commented Dec 17, 2020

Equals zero.

@dnsl48
Copy link
Owner

dnsl48 commented Dec 17, 2020

Hi @jgarvin, thank you for the patch!
Looks like we also miss the Default implementation for GenericFraction. I suggest we could add that one and fallback to GenericFraction::default() internally within GenericDecimal::default() implementation. What do you reckon?

@dnsl48 dnsl48 mentioned this pull request Dec 17, 2020
Closed
dnsl48
dnsl48 requested changes Dec 17, 2020
View reviewed changes
Copy link
Owner

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I left a suggestion in the comments to make it with GenericFraction::default().
We'll also need some tests for both Fraction and Decimal.

@dnsl48 dnsl48 closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsl48 dnsl48 dnsl48 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgarvin @dnsl48