Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Integrations documentation #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Geo25rey
Copy link
Contributor

Added documentation for both the Google Drive and Zoom Integrations.

@Geo25rey Geo25rey requested a review from vaultec81 March 25, 2021 18:19
Copy link
Contributor

@vaultec81 vaultec81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions here and there.

docs/docs/cli/integrations.md Outdated Show resolved Hide resolved

### Setup

There is currently no easy way to setup the Zoom Integration and is not currently supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace this line with coming soon or similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is coming soon. Last I heard, there aren't plans on going further with it for the time being.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe just remove the mention of Zoom entirely if it not something the user can use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is accessible thru the API tho

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geo25rey I would suggest adding some mention of the API in that case otherwise it would appear like we are offering a feature that isn't quite ready yet. Better to not confuse the reader with this.

docs/docs/cli/integrations.md Show resolved Hide resolved
docs/docs/cli/integrations.md Outdated Show resolved Hide resolved
@Geo25rey Geo25rey requested a review from vaultec81 March 25, 2021 21:04
@Geo25rey Geo25rey mentioned this pull request Mar 25, 2021

### Setup

There is currently no easy way to setup the Zoom Integration and is not currently supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment here is the only major thing that stands out. Maybe replace with coming soon?

@vaultec81 vaultec81 force-pushed the main branch 2 times, most recently from d7a2e96 to 45d5ed4 Compare April 8, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants