Speed up autocrop significantly #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use is() and is_deeply() instead of eq(). Also permit us to test for expected errors.
Saving the subtraction right at the end is not as useful as code clarity.
Some of the edge cases seem to confuse ImageMagick. Inconceivable!
Convert @range to a flat array.
|
That looks quite interesting, thanks. Would have to take a closer look during the weekend. Regarding the channels (1/3 vs 0/2) - that was more to avoid subtracting 1 way too often :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this module at work and it's very useful, but we sometimes have a lot of images to process and it can end up CPU bound. Hence:
The first commits add regression tests for
border, greyscale images,AUTOCROP_ERROR_BLANKAUTOCROP_ERROR_NOCROPand a lot of (literal) corner and edge cases.I then used these to refactor
_scanto be much faster - maybe twice to three times faster (estimated by eyeballing the progress logs, not be any proper benchmark).I hope that this is useful.