Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify config to export lib #89

Merged
merged 1 commit into from
Dec 29, 2018
Merged

fix: modify config to export lib #89

merged 1 commit into from
Dec 29, 2018

Conversation

miketdonahue
Copy link
Contributor

@miketdonahue miketdonahue commented Dec 29, 2018

Please fill in the template below before submitting your pull request. This helps keep a consistent structure for project history.

Metadata

  • Feature: a new feature.
  • Bug: a bug fix.
  • Refactor: a code change that neither fixes a bug nor adds a feature.
  • Style: changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.).
  • Test: adding missing tests or correcting existing tests.
  • Performance: a code change that improves performance.
  • Documentation: changes to documentation.
  • Build: changes that affect the build system or external dependencies.
  • CI: changes to our CI configuration files and scripts.
  • Chore: housekeeping changes that do not affect production.

Changes

Configs were incorrect to successfully export an ES5 library.

Checklist

  • This PR contains only a single concern and is small enough to be reviewed easily.
  • Documentation for this issue has been added or updated with this PR.
  • Unit tests have been added, if applicable.

Screenshots

Please include any relevant screenshots if this PR pertains to a visible UI change.

Additional Information

Please include any additional notes you feel are necessary here.

@auto-comment
Copy link

auto-comment bot commented Dec 29, 2018

Thank your for raising your pull request. Please make sure you have followed our contributing guidelines and have filled in the pull request template. We will review your pull request soon.

- Configs were incorrect to successfully export an ES5 library
@miketdonahue
Copy link
Contributor Author

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@miketdonahue miketdonahue added the released A feature or fix that has been released label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released A feature or fix that has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant