Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project api #239

Merged
merged 1 commit into from
Aug 17, 2022
Merged

feat: add project api #239

merged 1 commit into from
Aug 17, 2022

Conversation

randombenj
Copy link
Member

This change massively improves the usability while doing local
development. It also fixes #40.

The local development now also proxies the /api and /doc endpoints
from the backend (port 5000) through the frontend (port 8080)
making CORS handling simpler during development.

Copy link
Member

@fliiiix fliiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ✨ change ✨ i made some comments and i will look at it in-depth later

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
web/public/index.html Outdated Show resolved Hide resolved
web/vue.config.js Show resolved Hide resolved
This change massively improves the usability while doing local
development. It also fixes #40.

The local development now also proxies the `/api` and `/doc` endpoints
from the  backend (port 5000) through the frontend (port 8080)
making CORS handling simpler during development.
Copy link
Member

@fliiiix fliiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fliiiix fliiiix merged commit 848202b into main Aug 17, 2022
@fliiiix fliiiix deleted the add-project-api branch August 17, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 'latest' tag not as a version rather combine it like 1.2.3 (latest)'
3 participants