Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 487 add support for titleabbrev in bibliography entries. #492

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

fsteimke
Copy link
Contributor

No description provided.

@ndw
Copy link
Contributor

ndw commented Sep 21, 2024

Can you add a test that demonstrates this change? Abbreviated titles aren't generally presented inline; they're used for things like the table of contents. I'm not sure what you have in mind here.

@fsteimke
Copy link
Contributor Author

I was thinking of German legal texts. They usually have a very long title and an official abbreviation. An example would be:

  • title: "Gesetz zur Einführung und Verwendung einer Identifikationsnummer in der öffentlichen Verwaltung"
  • titleabbrev: "Identifikationsnummerngesetz" or even "IdNrG"

Since both the full title and the abbreviation are part of the official name, you would expect a reference to this law as: "Gesetz zur Einführung und Verwendung einer Identifikationsnummer in der öffentlichen Verwaltung (Identifikationsnummerngesetz)" or "Gesetz zur Einführung und Verwendung einer Identifikationsnummer in der öffentlichen Verwaltung (IdNrG)".

I admit that this seems to be a very specific use case. On the other hand, it is about the use of titleabbrev within the bibliography only. I don't see the risk of unwanted effects with normal use of titleabbrev for ToC.

I will add test cases (biblioentry and bibliomixed).

@ndw
Copy link
Contributor

ndw commented Oct 11, 2024

Yes, I see your point.

@fsteimke
Copy link
Contributor Author

The PR should support titleabbrev in biblioentry as well as in bibliomixed.

It was difficult to add parenthesis around abbreviated title in the same font-style as the abbreviated title itself. The best way i found was to hard-code them in CSS. Maybe you find a better way?

I had to change the expected HTML for bibliography.001 and bibliography.002, but i think in a very natural way.

@ndw ndw merged commit b878b69 into docbook:main Oct 20, 2024
2 checks passed
@fsteimke fsteimke deleted the 487-titleabbrev branch October 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants