Doccano 1.7 compatibility update #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
houssam7737
reviewed
Oct 4, 2022
|
Overall looks very solid with a great test suite. A couple minor suggestions to improve documentation and I think this should be ready to merge! Thanks for your contribution! (with your update the client should now be fully operational with Doccano 1.7) |
|
Addressed the comments! |
houssam7737
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing tests for span, span-type, relation, relation-type
Adds category and category-type controllers for Document Classification projects plus corresponding tests
Adds text controller for Seq2seq projects plus corresponding tests
Updates api endpoints for labels and comments
Fixes bug with project attributes