This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
remove \b (\u0008) prefix from /info api calls #1238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicate of #1147 |
|
@vieux It seems like we're mixing data with presentation here? This does appear to breaking the ability to programmatically parse the output (as noted in #1214). It seems like this should be modified in the cli where output presentation is formatted, would you be able point me in the right direction, I'll be happy to take a crack at fixing it. |
Signed-off-by: Justin Clark <u2mejc@users.noreply.github.com>
u2mejc
force-pushed
the
jc-info-api1
branch
from
1b7ec10
to
70d6277
Compare
|
@u2mejc I agree it's not good as it is right now, changing the docker cli would be better so we could remove the \b in swarm. |
|
Closing this PR since it needs more changes. Follow the discussion on #1625 instead. |
|
This is fixed in #1721 🎉 |
|
@nishanttotla and @vieux, thank you! I'm looking forward to testing master as time allows! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #1237