Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] backport Fix error with merge composefile with networks… #495

Merged

Conversation

thaJeztah
Copy link
Member

backport of docker/cli#981 and docker/cli#983 for 18.03

git checkout -b 18.03-backport-972-fix-merge-network upstream/18.03
git cherry-pick -s -S -x -Xsubtree=components/cli 2ee9635b1e7163aaea285a2f58033575f8b0e4ed
git cherry-pick -s -S -x -Xsubtree=components/cli 0122730faf7136feb020078058537382fcc8413e
git push -u origin 18.03-backport-972-fix-merge-network

no conflicts

@thaJeztah thaJeztah added this to the 18.03.1 milestone Apr 5, 2018
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah
Copy link
Member Author

17:17:07 Makefile:15: recipe for target 'test-unit' failed
17:17:07 make: *** [test-unit] Error 2
17:17:07 Makefile-docker-ce:79: recipe for target 'client-unit-test' failed
17:17:07 make: *** [client-unit-test] Error 2
17:19:23 runner/runner.go:12:2: cannot find package "gopkg.in/fsnotify.v1" in any of:
17:19:23 	/usr/local/go/src/gopkg.in/fsnotify.v1 (from $GOROOT)
17:19:23 	/go/src/gopkg.in/fsnotify.v1 (from $GOPATH)

arf, we need to backport docker/cli#955

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit 2ee9635b1e7163aaea285a2f58033575f8b0e4ed)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
… and other cases too. Updating mergo fixes the bugs (but introduced a
slight behaviour change that had to be fixed too)

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit 0122730faf7136feb020078058537382fcc8413e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 18.03-backport-972-fix-merge-network branch from 14ab1bb to d6931c2 Compare April 11, 2018 21:47
@thaJeztah
Copy link
Member Author

ping @andrewhsu this is green 👍

@andrewhsu andrewhsu merged commit d602967 into docker-archive:18.03 Apr 17, 2018
@thaJeztah thaJeztah deleted the 18.03-backport-972-fix-merge-network branch April 17, 2018 05:00
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 24, 2020
…72-fix-merge-network

[18.03] backport Fix error with merge composefile with networks…
docker-jenkins pushed a commit that referenced this pull request May 15, 2020
full diff: gorilla/mux@v1.7.3...v1.7.4

v1.7.4 addresses a number of performance improvements, bugs, and documentation
improvements.

- Reduce allocations in (*routeRegexp).getURLQuery
- Fixed golint warnings
- fix headers regexp test case
- Fix the CORSMethodMiddleware bug with subrouters
- Remove/cleanup request context helpers
- Guess the scheme if r.URL.Scheme is unset
- Added capacity to slice creation, when capacity is known
- Modified http status codes, using constants provided by the http package
- bugfix/subrouter custom methodNotAllowed handler returning 404
- Update README (self-host logo)
- Remove TravisCI badge
- Add documentation for using mux to serve a SPA
- Simplify code
- Avoid unnecessary conversion
- Update config.yml (#495) @elithrar

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 5fd3496e7a96440bc1b08d16cc36f306b6e43665
Component: engine
docker-jenkins pushed a commit that referenced this pull request Jun 25, 2020
full diff: gorilla/mux@v1.7.3...v1.7.4

v1.7.4 addresses a number of performance improvements, bugs, and documentation
improvements.

- Reduce allocations in (*routeRegexp).getURLQuery
- Fixed golint warnings
- fix headers regexp test case
- Fix the CORSMethodMiddleware bug with subrouters
- Remove/cleanup request context helpers
- Guess the scheme if r.URL.Scheme is unset
- Added capacity to slice creation, when capacity is known
- Modified http status codes, using constants provided by the http package
- bugfix/subrouter custom methodNotAllowed handler returning 404
- Update README (self-host logo)
- Remove TravisCI badge
- Add documentation for using mux to serve a SPA
- Simplify code
- Avoid unnecessary conversion
- Update config.yml (#495) @elithrar

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: e64d6d9ed75f25b519b9e68ca97ea8175543100d
Component: cli
docker-jenkins pushed a commit that referenced this pull request Aug 24, 2020
[master] plugins: update buildx to v0.4.2
Upstream-commit: 26b8ce6
Component: packaging
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
[master] plugins: update buildx to v0.4.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants