This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Allow --detach and --quiet flags when using --rollback #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 78c204ef798c7380e11ba26e5cd231e04fc6efe4 added (f9bd8ec in the moby repo) a validation to prevent `--rollback` from being used in combination with other flags that update the service spec. This validation was not taking into account that some flags only affect the CLI behavior, and are okay to be used when rolling back. This patch updates the validation, and adds `--quiet` and `--detach` to the list of allowed flags. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit f10f29df8d7ffede3faa29120a06c199e52a1d0c) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
40 tasks
|
LGTM |
andrewhsu
pushed a commit
that referenced
this pull request
Dec 4, 2017
use golang 1.9.2 Upstream-commit: ca48d41 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 22, 2018
[18.09] Remove boltdb dependency Upstream-commit: ccab60936554e7bbcc06d507b5d9217ed0f80f69 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
Allow --detach and --quiet flags when using --rollback
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
use golang 1.9.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from: docker/cli#144
Commit 78c204ef798c7380e11ba26e5cd231e04fc6efe4 added
(f9bd8ec in the moby repo)
a validation to prevent
--rollbackfrom being usedin combination with other flags that update the
service spec.
This validation was not taking into account that
some flags only affect the CLI behavior, and
are okay to be used when rolling back.
This patch updates the validation, and adds
--quietand--detachto the list of allowedflags.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit f10f29df8d7ffede3faa29120a06c199e52a1d0c)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com