Update Joomla stack/compose example #1121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README example of a stack.yml file could use updating to remove legacy/confusing options: 1. Links are no longer needed as of compose v2. Since this example uses v3.1, links should be removed. 2. restart: option is only used for docker-compose, while restart_policy: is only used for stack deploy. Since it's an option setting, I'd recommend removing it from the example to avoid confusion like this question on SO.
|
Can you move this to stack.yml? As for the content of the change, I think keeping cc @tianon |
|
Almost all our "stack.yml" files are intentionally written to work roughly
the same via both "docker-compose" and "docker stack deploy" as much as
they can, which is why we include things like "restart: always" (which is
effectively the default in swarm mode).
|
|
OK I'll move, sorry about that, and keep restart... so this will just be removing links :) |
|
🙇 I'm going to close this now -- if you believe it's still relevant, feel free to open a new PR. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Joomla README example of a stack.yml file could use updating to remove legacy/confusing options: