Adjust PHP documentation organization, especially to utilize "variants" template functionality #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
previously requested changes
Nov 21, 2018
php/variant-apache.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| ## `%%IMAGE%%:<version>-apache | |||
There was a problem hiding this comment.
I blame the fellow I stole most of this content from while it was still a WIP on his computer. 😉 😄
php/variant-fpm.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| ## `%%IMAGE%%:<version>-fpm | |||
…s" template functionality This will hopefully help clarify some of the image variants and should remove things like the Apache documentation from arm32v6/php (where the image doesn't exist so the documentation doesn't apply).
tianon
force-pushed
the
improve-php-docs
branch
from
c814597
to
837c4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully help clarify some of the image variants and should remove things like the Apache documentation from arm32v6/php (where the image doesn't exist so the documentation doesn't apply).
Closes docker-library/php#741
Refs docker-library/wordpress#346 (comment)